[webkit-reviews] review granted: [Bug 4026] Math.random() not seeded : [Attachment 5325] Fix 3

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Wed Dec 28 16:36:22 PST 2005

Maciej Stachowiak <mjs at apple.com> has granted Geoffrey Garen
<ggaren at apple.com>'s request for review:
Bug 4026: Math.random() not seeded

Attachment 5325: Fix 3

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
r=me, to address Darin's concern, the PLT could do what it does after ensuring
that at least one random number has  been generated, since this latest patch
promises one time only seeding.

Class scope statics do need to be initialized, but you could make it file
scope, then there is no need to mention it in the header. It is better to leave
implementation details out of headers when possible IMO.

More information about the webkit-reviews mailing list