[webkit-reviews] review denied: [Bug 4026] Math.random() not seeded : [Attachment 5304] Fix 2

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Tue Dec 27 14:31:36 PST 2005


Maciej Stachowiak <mjs at apple.com> has denied Geoffrey Garen
<ggaren at apple.com>'s request for review:
Bug 4026: Math.random() not seeded
http://bugzilla.opendarwin.org/show_bug.cgi?id=4026

Attachment 5304: Fix 2
http://bugzilla.opendarwin.org/attachment.cgi?id=5304&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
Actually, now that I look more closely - shouldn't randomSeeded be a static
variable, rather than a field of MathFunctionImp? As it is, every interpreter
will reseed the RNG on the first call to Math.random, that doesn't seem to be
what we want.



More information about the webkit-reviews mailing list