[webkit-reviews] review granted: [Bug 6250] Implement Array.map and Array.filter : [Attachment 5300] Implement functions

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Tue Dec 27 09:06:44 PST 2005

Darin Adler <darin at apple.com> has granted Anders Carlsson <andersca at mac.com>'s
request for review:
Bug 6250: Implement Array.map and Array.filter

Attachment 5300: Implement functions

------- Additional Comments from Darin Adler <darin at apple.com>
Seems a bit of a shame to first do hasProperty and then get on each property.
Given the "property slot" architecture we could come up with a design that only
does a single lookup for each property, but I suppose that's probably an
unimportant optimization.

Since this introduces a distinction between properties with the value
"undefined" and "undefined properties" I'd like to see at least one test
proving that distinction exists.

Looks great, r=me.

More information about the webkit-reviews mailing list