[webkit-reviews] review denied: [Bug 5311] localtime_r,
gmtime_r... not available on Win32 (possibly other systems?) :
[Attachment 5290] localtime_r,
gmtime_r implemented using secure gmtime/localtime
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Mon Dec 26 18:05:58 PST 2005
Darin Adler <darin at apple.com> has denied Justin Haygood <jhaygood at spsu.edu>'s
request for review:
Bug 5311: localtime_r, gmtime_r... not available on Win32 (possibly other
systems?)
http://bugzilla.opendarwin.org/show_bug.cgi?id=5311
Attachment 5290: localtime_r, gmtime_r implemented using secure
gmtime/localtime
http://bugzilla.opendarwin.org/attachment.cgi?id=5290&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
Using the secure version is OK, although it doesn't help with the issue that
"_r" deals with, but why use the 64-bit version? The parameter is just a
time_t, so there's no benefit to using the 64-bit one.
The basic concept of the changes to work on Windows are good, but lets not land
this with the "64" variant.
More information about the webkit-reviews
mailing list