[webkit-reviews] review denied: [Bug 5311] localtime_r, gmtime_r... not available on Win32 (possibly other systems?) : [Attachment 5285] Adds localtime_r, gmtime_r support

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Mon Dec 26 10:40:40 PST 2005


Eric Seidel <macdome at opendarwin.org> has denied Justin Haygood
<jhaygood at spsu.edu>'s request for review:
Bug 5311: localtime_r, gmtime_r... not available on Win32 (possibly other
systems?)
http://bugzilla.opendarwin.org/show_bug.cgi?id=5311

Attachment 5285: Adds localtime_r, gmtime_r support
http://bugzilla.opendarwin.org/attachment.cgi?id=5285&action=edit

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
Is localtime() threadsafe under windows??  Otherwise this would not be OK. 
Also, if so this shoudl be inside a __WIN32__ block, as this is certainly not
OK for unix systems, where localtime() is not threadsafe.



More information about the webkit-reviews mailing list