[webkit-reviews] review granted: [Bug 6083] REGRESSION: 5-10%
performance regression on JS iBench from getter/setter change :
[Attachment 5282] this one gets the regression down to ~1% and doesn't break
anything afaik
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Mon Dec 26 09:08:39 PST 2005
Darin Adler <darin at apple.com> has granted Maciej Stachowiak <mjs at apple.com>'s
request for review:
Bug 6083: REGRESSION: 5-10% performance regression on JS iBench from
getter/setter change
http://bugzilla.opendarwin.org/show_bug.cgi?id=6083
Attachment 5282: this one gets the regression down to ~1% and doesn't break
anything afaik
http://bugzilla.opendarwin.org/attachment.cgi?id=5282&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
JSObject::getOwnPropertySlot should use the ALWAYS_INLINE macro rather than
doing it directly.
Why do the hasGetterSetterProperties() and setHasGetterSetterProperties()
functions have commented out code instead of the real code?
Otherwise, looks good. r=me
More information about the webkit-reviews
mailing list