[webkit-reviews] review granted: [Bug 6241] Remove WebFrame's parent frame pointer, instead rely on WebCore's parent concept : [Attachment 5280] change to do it

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Dec 25 21:45:55 PST 2005


Geoffrey Garen <ggaren at apple.com> has granted Maciej Stachowiak
<mjs at apple.com>'s request for review:
Bug 6241: Remove WebFrame's parent frame pointer, instead rely on WebCore's
parent concept
http://bugzilla.opendarwin.org/show_bug.cgi?id=6241

Attachment 5280: change to do it
http://bugzilla.opendarwin.org/attachment.cgi?id=5280&action=edit

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
Looks good.

I think these lines

	 for (i = [_private->children count]-1; i >=0; i--) {
	     [[_private->children objectAtIndex:i] _detachFromParent];
-	     [_private->children removeObjectAtIndex:i];
	 }

now have braces that don't belong.



More information about the webkit-reviews mailing list