[webkit-reviews] review granted: [Bug 6228] DOMString/DOMStringImpl/AtomicString need enhancements before replacing QString : [Attachment 5268] Other string uses (including some unrelated cleanup)

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Dec 25 02:13:01 PST 2005


Maciej Stachowiak <mjs at apple.com> has granted Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 6228: DOMString/DOMStringImpl/AtomicString need enhancements before
replacing QString
http://bugzilla.opendarwin.org/show_bug.cgi?id=6228

Attachment 5268: Other string uses (including some unrelated cleanup)
http://bugzilla.opendarwin.org/attachment.cgi?id=5268&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
+	     if (str.find("url", 0,  false ) == 0)

replace with startsWith?

otherwise r=me



More information about the webkit-reviews mailing list