[webkit-reviews] review denied: [Bug 6228] DOMString/DOMStringImpl/AtomicString need enhancements before replacing QString : [Attachment 5267] Use new string methods in khtml/css

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Dec 25 01:15:35 PST 2005


Maciej Stachowiak <mjs at apple.com> has denied Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 6228: DOMString/DOMStringImpl/AtomicString need enhancements before
replacing QString
http://bugzilla.opendarwin.org/show_bug.cgi?id=6228

Attachment 5267: Use new string methods in khtml/css
http://bugzilla.opendarwin.org/attachment.cgi?id=5267&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
+    bool important = priority.find("important", 0, false) != -1;

Replace this with startsWith for clarity maybe?

-	     refPos = path.find("#", 0);
+	     refPos = path.find("#");

r- because of this apparent bug (or possible undocumented fix) otherwise looks
fine.



More information about the webkit-reviews mailing list