[webkit-reviews] review granted: [Bug 6230] Remove QDict from khtml/html : [Attachment 5270] proposed patch.

[bugzilla-request-daemon at opendarwin.org]

Maciej Stachowiak <mjs at apple.com> has granted Maciej Stachowiak
<mjs at apple.com>'s request for review:
Bug 6230: Remove QDict from khtml/html
http://bugzilla.opendarwin.org/show_bug.cgi?id=6230

Attachment 5270: proposed patch.
http://bugzilla.opendarwin.org/attachment.cgi?id=5270&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
+		 info->idCache.add(idAttrVal.impl(), idVector);

I think it would be better to use set() instead of add() here, just because it
has a more obvious semantic. On the other hand, it would be a leak (with either
set or add!) if there were already a value set for that id, so maybe ASSERT
that that's not the case?

Same comment:

+		 info->nameCache.add(nameAttrVal.impl(), nameVector);

These both come up more than once.


r=me despite this minor style nitpick.