[webkit-reviews] review granted: [Bug 6208] Replace QDict with HashMap for XSLTProcessorImpl param dictionary : [Attachment 5232] patch to do it

[bugzilla-request-daemon at opendarwin.org]

Eric Seidel <macdome at opendarwin.org> has granted Maciej Stachowiak
<mjs at apple.com>'s request for review:
Bug 6208: Replace QDict with HashMap for XSLTProcessorImpl param dictionary
http://bugzilla.opendarwin.org/show_bug.cgi?id=6208

Attachment 5232: patch to do it
http://bugzilla.opendarwin.org/attachment.cgi?id=5232&action=edit

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
The patch looks fine.  I'm not quite sure why passing the parameters is not
working.  We talked over IRC and mjs verified that the parameter array was
being properly constructed...

Maciej, you might try passing in latin1 encoded parameters instead of UTF8,
given that the arg is specified as const char ** and not xmlChar **, if that
works, great!  If not, it's still OK to land.

There are some tabs in your ChangeLog.

I would also run-webkit-tests --leaks fast/xsl before landing just to make
sure.