[webkit-reviews] review granted: [Bug 3565] Posting data via XMLHttpRequest doesn't work (wrong Content-Type) : [Attachment 5219] proposed fix

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Thu Dec 22 06:36:28 PST 2005


Eric Seidel <macdome at opendarwin.org> has granted Alexey Proskuryakov
<ap at nypop.com>'s request for review:
Bug 3565: Posting data via XMLHttpRequest doesn't work (wrong Content-Type)
http://bugzilla.opendarwin.org/show_bug.cgi?id=3565

Attachment 5219: proposed fix
http://bugzilla.opendarwin.org/attachment.cgi?id=5219&action=edit

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
ap and I talked over IRC.  ap noted that there could be security concerns wrt
our setRequestHeader support on XMLHTTPRequest.  He was able to convince me
however that this patch does not introduce any additional security risk, mearly
adds support for respecting content-type headers which one was already able to
set.

ap agreed to file additional bugs on the subject.

The patch itself appeared to me to be technically sound.

The FireFox bugs in question are:
https://bugzilla.mozilla.org/show_bug.cgi?id=302809
https://bugzilla.mozilla.org/show_bug.cgi?id=302263
https://bugzilla.mozilla.org/show_bug.cgi?id=308484



More information about the webkit-reviews mailing list