[webkit-reviews] review granted: [Bug 6177] move event code from
JavaScript binding into DOM implementation :
[Attachment 5199] do the work in the DOM implementation,
not the JavaScript binding
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Wed Dec 21 09:39:53 PST 2005
Geoffrey Garen <ggaren at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 6177: move event code from JavaScript binding into DOM implementation
http://bugzilla.opendarwin.org/show_bug.cgi?id=6177
Attachment 5199: do the work in the DOM implementation, not the JavaScript
binding
http://bugzilla.opendarwin.org/attachment.cgi?id=5199&action=edit
------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
Looks good, r=me.
Since you needed a comment to explain what viewportToContents does, and since
I'm not quite sure what absolutePosition does (all coordinates are relative to
*something* -- does absolute mean relative to the screen?), I think it would be
good to rename them soon.
More information about the webkit-reviews
mailing list