[webkit-reviews] review requested: [Bug 6139] ATSUI code path should implement small caps, synthetic bold and oblique and correct metrics for fallback fonts : [Attachment 5140] Patch (incl. layout test)

[bugzilla-request-daemon at opendarwin.org]

opendarwin.org at mitzpettel.com has asked  for review:
Bug 6139: ATSUI code path should implement small caps, synthetic bold and
oblique and correct metrics for fallback fonts
http://bugzilla.opendarwin.org/show_bug.cgi?id=6139

Attachment 5140: Patch (incl. layout test)
http://bugzilla.opendarwin.org/attachment.cgi?id=5140&action=edit

------- Additional Comments from opendarwin.org at mitzpettel.com
The code changes in this patch combine attachment 4966 and attachment 4968,
changing several YES/NO to true/false and adding

+		 if (!u_isbase(c))
+		     renderers[i] = isSmallCap ? getSmallCapsRenderer(r) : r;

to make sure that combining marks stay in the same renderer as the base
character preceding them.