[webkit-reviews] review granted: [Bug 6106] DOMString should hold its impl in a RefPtr : [Attachment 5104] Proposed patch.

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Fri Dec 16 07:30:46 PST 2005

Darin Adler <darin at apple.com> has granted Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 6106: DOMString should hold its impl in a RefPtr

Attachment 5104: Proposed patch.

------- Additional Comments from Darin Adler <darin at apple.com>
A couple refinements you could do before landing:

With this change, ~DOMString, DOMString(const DOMString &), and
DOMString::operator= don't need to be explicitly declared or implemented. The
default generated ones will do the right thing without any code.

(The same would be true of the default constructor except that as I recall the
default constructor is only generated if you don't delcare any others.)

Also, you should replace tabs with spaces in these files (patches show many

More information about the webkit-reviews mailing list