[webkit-reviews] review requested: [Bug 6109] khtml/editing should
use RefPtr instead of manual ref/deref :
[Attachment 5106] Proposed patch.
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Fri Dec 16 02:09:52 PST 2005
Eric Seidel <macdome at opendarwin.org> has asked for review:
Bug 6109: khtml/editing should use RefPtr instead of manual ref/deref
http://bugzilla.opendarwin.org/show_bug.cgi?id=6109
Attachment 5106: Proposed patch.
http://bugzilla.opendarwin.org/attachment.cgi?id=5106&action=edit
------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
Unfortunately this one is the biggest of the bunch, and the most complex. I
can break it up into smaller chunks if that would be better.
A reviewer should look for the same things as with any RefPtr patch:
1. Did I mark the same instance variables RefPtr<Foo> as I removed
ref()/deref() methods for?
2. Did I remember to remove any m_foo(0) initializers
3. Did I mark some variable m_foo as a RefPtr when it really should have been
a weak reference?
I've of course looked for all these already... but those are the main things
that can go wrong in this kind of patch.
More information about the webkit-reviews
mailing list