[webkit-reviews] review granted: [Bug 6101] Leaks in
XSLTProcessorImpl due to early-exit in failure case :
[Attachment 5099] Proposed patch
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Thu Dec 15 21:53:23 PST 2005
Darin Adler <darin at apple.com> has granted Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 6101: Leaks in XSLTProcessorImpl due to early-exit in failure case
http://bugzilla.opendarwin.org/show_bug.cgi?id=6101
Attachment 5099: Proposed patch
http://bugzilla.opendarwin.org/attachment.cgi?id=5099&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
If the sourceDoc comes back 0, should we be returning true or false? This code
returns true. Otherwise, looks fine. I guess I'll say review+.
More information about the webkit-reviews
mailing list