[webkit-reviews] review granted: [Bug 6094] khtml/css should use RefPtr instead of manual ref() deref() : [Attachment 5085] Proposed patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Thu Dec 15 06:27:06 PST 2005

Darin Adler <darin at apple.com> has granted Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 6094: khtml/css should use RefPtr instead of manual ref() deref()

Attachment 5085: Proposed patch

------- Additional Comments from Darin Adler <darin at apple.com>
To avoid leaks, getPropertyCSSValue should be changed to return a PassRefPtr
rather than a raw pointer.

CSSStyleRuleImpl::setDeclaration doesn't need the != check. It can just be a
one-liner m_style = style.

The changes to CSSPrimitiveValueImpl don't seem like much of an improvement to

~CSSProperty should be removed altogether rather than left declared as an empty

In this line:


there's a space missing after the > symbol.

But none of these are major issues, it's fine to land as-is if you like.

More information about the webkit-reviews mailing list