[webkit-reviews] review granted: [Bug 6094] khtml/css should use RefPtr instead of manual ref() deref() : [Attachment 5085] Proposed patch

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has granted Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 6094: khtml/css should use RefPtr instead of manual ref() deref()
http://bugzilla.opendarwin.org/show_bug.cgi?id=6094

Attachment 5085: Proposed patch
http://bugzilla.opendarwin.org/attachment.cgi?id=5085&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
To avoid leaks, getPropertyCSSValue should be changed to return a PassRefPtr
rather than a raw pointer.

CSSStyleRuleImpl::setDeclaration doesn't need the != check. It can just be a
one-liner m_style = style.

The changes to CSSPrimitiveValueImpl don't seem like much of an improvement to
me.

~CSSProperty should be removed altogether rather than left declared as an empty
inline.

In this line:

     RefPtr<CSSMutableStyleDeclarationImpl>dummyStyleDeclaration

there's a space missing after the > symbol.

But none of these are major issues, it's fine to land as-is if you like.