[webkit-reviews] review granted: [Bug 6061] Crash on
http://me.in-berlin.de/~darwin/svg/incoming/Drawing5.svg :
[Attachment 5058] Crasher fix (also cleans up a bit,
and fixes other crashers)
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Tue Dec 13 08:06:04 PST 2005
Darin Adler <darin at apple.com> has granted Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 6061: Crash on http://me.in-berlin.de/~darwin/svg/incoming/Drawing5.svg
http://bugzilla.opendarwin.org/show_bug.cgi?id=6061
Attachment 5058: Crasher fix (also cleans up a bit, and fixes other crashers)
http://bugzilla.opendarwin.org/attachment.cgi?id=5058&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
Looks fine.
Code could be a lot more terse and slightly easier to read by leaving out the
unneeded QString::fromLatin1 calls. Just using a "" string is fine for these
plain-ASCII strings, as is QString("") if there's some ambiguity.
r=me
More information about the webkit-reviews
mailing list