[webkit-reviews] review granted: [Bug 6039] Update
KCanvasFiltersQuartz.mm to match style guidelines :
[Attachment 5025] Code cleanup to match style guidelines (mostly spacing
changes)
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Sun Dec 11 17:09:30 PST 2005
Darin Adler <darin at apple.com> has granted Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 6039: Update KCanvasFiltersQuartz.mm to match style guidelines
http://bugzilla.opendarwin.org/show_bug.cgi?id=6039
Attachment 5025: Code cleanup to match style guidelines (mostly spacing
changes)
http://bugzilla.opendarwin.org/attachment.cgi?id=5025&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
+static QString KCPreviousFilterOutputName = QString("__previousOutput__");
The above should just be:
static QString KCPreviousFilterOutputName = "__previousOutput__";
r=me on this change
Reading this code I see lots to comment on that has nothing to do with what the
patch changes -- maybe as part of code review.
More information about the webkit-reviews
mailing list