[webkit-reviews] review granted: [Bug 5987] <applet> is broken in xhtml : [Attachment 4986] Better patch (correctly handles implicit elements)

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Wed Dec 7 09:58:30 PST 2005

Darin Adler <darin at apple.com> has granted Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 5987: <applet> is broken in xhtml

Attachment 4986: Better patch (correctly handles implicit elements)

------- Additional Comments from Darin Adler <darin at apple.com>
There are three changes here.

One is to call closeRenderer. That looks fine.

Another is to set m_currentNode to the grandparent of the implicit node rather
than the parent of the implicit node. That also seems fine, because we need to
close the element.

The third change is to remove NULL checks. That one worries me a bit, but I
guess we can count on not getting an endElement callback unless we have
successfully started and element. It's worth looking closely at that. What
happens if the startElement fails?


More information about the webkit-reviews mailing list