[webkit-reviews] review granted: [Bug 5744] xmlhttprequest does not apply page encoding after assigning via innerHtml : [Attachment 4948] updated patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Mon Dec 5 06:51:00 PST 2005

Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at nypop.com>'s
request for review:
Bug 5744: xmlhttprequest does not apply page encoding after assigning via

Attachment 4948: updated patch

------- Additional Comments from Darin Adler <darin at apple.com>
If this function is going to share quirks with the decoder, then I think it
should be moved to be a static member function of Decoder so we can fix both at
the same time. I know you were discussing where it should go, and I think that
would be the right thing to do.

In general I'm not happy with these getMIMEType and getCharset functions.
getMIMEType splits the entire string into a list and then just uses the first
piece -- that's a bit inefficient since you really just want to search for the
first ";" and get the whitespace-stripped sequence up until that.

But then getCharset goes the other way and instead of parsing the
semicolon-separated string into pieces and looking at each one for charset, it
scans the entire string for the substring "charset" and then tries to figure
things out from there.

In both cases we could write something that was both correct and relatively

But for this patch, I think we're OK. This is good enough ot fix the bug. Lets
land it. r=me

More information about the webkit-reviews mailing list