[webkit-reviews] review requested: [Bug 5747] KCPathData needs to be redesigned : [Attachment 4963] replace KCPathDataList & KCanvasUserData with KCanvasPath (abstract)

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Mon Dec 5 06:12:19 PST 2005


Eric Seidel <macdome at opendarwin.org> has asked	for review:
Bug 5747: KCPathData needs to be redesigned
http://bugzilla.opendarwin.org/show_bug.cgi?id=5747

Attachment 4963: replace KCPathDataList & KCanvasUserData with KCanvasPath
(abstract)
http://bugzilla.opendarwin.org/attachment.cgi?id=4963&action=edit

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
See comments in the bug.  This is a pretty straightforward patch.  I welcome
anyone to give it a go.  There are a couple things you will see here:

1.  Removing KCanvasUserData and KCPathData/KCPathDataList, instead replacing
them with KCanvasPath*.

2.  Several places where I renamed "list" to "path" and change . access to ->.

3.  Flat-out removal of several unneeded methods from KRenderingDeviceQuartz,
KCanvasCreator, KCanvasMatrix.

4.  Minor adjustments to the rest of the code to use the new KCanvasPath type.



More information about the webkit-reviews mailing list