[webkit-reviews] review denied: [Bug 3999] Object.prototype is
missing propertyIsEnumerable : [Attachment 4949] Address comments
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Sun Dec 4 15:18:48 PST 2005
Geoffrey Garen <ggaren at apple.com> has denied Anders Carlsson
<andersca at mac.com>'s request for review:
Bug 3999: Object.prototype is missing propertyIsEnumerable
http://bugzilla.opendarwin.org/show_bug.cgi?id=3999
Attachment 4949: Address comments
http://bugzilla.opendarwin.org/attachment.cgi?id=4949&action=edit
------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
ggaren: andersca:
[3:10pm] ggaren: + return !(attributes & DontEnum);
[3:10pm] ggaren: is backwards, no?
[3:12pm] ggaren: + putDirect(valueOfPropertyName, new
ObjectProtoFuncImp(exec, funcProto, ObjectProtoFuncImp::ValueOf,
0), DontEnum);
[3:12pm] ggaren: has an extra space
Otherwise, looks great.
More information about the webkit-reviews
mailing list