[webkit-reviews] review denied: [Bug 3999] Object.prototype is missing propertyIsEnumerable : [Attachment 4942] Implement propertyIsEnumerable

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Dec 4 13:42:07 PST 2005

Geoffrey Garen <ggaren at apple.com> has denied Anders Carlsson
<andersca at mac.com>'s request for review:
Bug 3999: Object.prototype is missing propertyIsEnumerable

Attachment 4942: Implement propertyIsEnumerable

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
isPropertyEnumerable should just call ObjectImp::get instead of doing the
lookup manually.

The putDirect calls need spaces after the commas, per our style guidelines.

r- because of the above.

I think it would be clearer if you named the C++ function propertyIsEnumerable
instead of isPropertyEnumerable, to match the name of the corresponding
(admittedly poorly named) JS function. I'll leave that decision up to you.

More information about the webkit-reviews mailing list