[webkit-reviews] review denied: [Bug 5744] xmlhttprequest does not apply page encoding after assigning via innerHtml : [Attachment 4937] updated patch

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has denied Alexey Proskuryakov <ap at nypop.com>'s
request for review:
Bug 5744: xmlhttprequest does not apply page encoding after assigning via
innerHtml
http://bugzilla.opendarwin.org/show_bug.cgi?id=5744

Attachment 4937: updated patch
http://bugzilla.opendarwin.org/attachment.cgi?id=4937&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Still looks wrong to me. This looks for charset, and if it's not at the
beginning of a word, just returns from the entire function. That doesn't make
sense to me. I think maybe you want to do "continue" in that case to look for
the next occurence of the string "charset".

I also think the test for word boundary seems strange. Why include all control
characters, semicolon, and quote marks? This would parse this:

    ignoreString="charset=UTF-8"

as a charset option, and there's no reason to parse in a way that allows that.

The skip whitespace code actually skips all characters <= ' ' which includes
things other than whitespace.

There's no reason to make this function strange in these respects. It could be
coded to match RFC 2616 instead.