[webkit-reviews] review denied: [Bug 5744] xmlhttprequest does not apply page encoding after assigning via innerHtml : [Attachment 4925] updated patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Dec 4 04:29:12 PST 2005

Darin Adler <darin at apple.com> has denied Alexey Proskuryakov <ap at nypop.com>'s
request for review:
Bug 5744: xmlhttprequest does not apply page encoding after assigning via

Attachment 4925: updated patch

------- Additional Comments from Darin Adler <darin at apple.com>
The algorithm in getCharset isn't quite right. It's not correct to look for
"charset" and then look for a "=" after it -- there might be the letter "x"
just before the string "charset", and this code would allow that. You should
fix that aspect of the getCharset function.

For getResponseHeader, I do think a separate bool is nice and clear, but there
is the distinct "null" value in QString that you could have used instead. I
think I'd prefer that because it makes the JavaScript version more consistent
with the C++ version.

Future direction: To fit in with the rest of the DOM bindings, the way this
class should work some day is that there is an XMLHttpRequest class that is not
part of the JavaScript bindings, but rather part of the "DOM" implementation.
Functions like getResponseHeader which are exported should both take and return
DOM strings, just like the functions in classes like DOM::NodeImpl and

More information about the webkit-reviews mailing list