[webkit-reviews] review requested: [Bug 5744] xmlhttprequest does not apply page encoding after assigning via innerHtml : [Attachment 4925] updated patch

[bugzilla-request-daemon at opendarwin.org]

Alexey Proskuryakov <ap at nypop.com> has asked Darin Adler <darin at apple.com> for
review:
Bug 5744: xmlhttprequest does not apply page encoding after assigning via
innerHtml
http://bugzilla.opendarwin.org/show_bug.cgi?id=5744

Attachment 4925: updated patch
http://bugzilla.opendarwin.org/attachment.cgi?id=4925&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at nypop.com>
We have discussed code reuse in getCharset() with MacDome on IRC. Similar code
is available in khtml::Decoder and as an SPI in Foundation.

However, the Foundation version is much less permissive (doesn't even seem to
handle quoted values), and the Decoder one has somewhat different logic that
makes code reuse quite problematic IMO.

So, I'm proposing this version - while a longer-term solution may be to fix and
leverage that Foundation SPI. And/or to split out the Decoder logic to be
reusable.