[webkit-reviews] review denied: [Bug 5921] Hit-testing text in overflows does not take scrolling into account : [Attachment 4914] suggested patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sat Dec 3 08:57:37 PST 2005


Darin Adler <darin at apple.com> has denied opendarwin.org at mitzpettel.com's
request for review:
Bug 5921: Hit-testing text in overflows does not take scrolling into account
http://bugzilla.opendarwin.org/show_bug.cgi?id=5921

Attachment 4914: suggested patch
http://bugzilla.opendarwin.org/attachment.cgi?id=4914&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
This looks like a really great fix to me. However, I think that
containingBlock() can be a relatively complicated calculation, so it should be
put in a local variable since we're using it three times in a row.



More information about the webkit-reviews mailing list