[webkit-reviews] review granted: [Bug 4573] click DOM method not working on check boxes or radio buttons : [Attachment 3496] patch to check on khtmlClick rather than click, not insist on a mouse event

[bugzilla-request-daemon at opendarwin.org]

Maciej Stachowiak <mjs at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 4573: click DOM method not working on check boxes or radio buttons
http://bugzilla.opendarwin.org/show_bug.cgi?id=4573

Attachment 3496: patch to check on khtmlClick rather than click, not insist on
a mouse event
http://bugzilla.opendarwin.org/attachment.cgi?id=3496&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
Assuming you tested this with both click() and real mouse clicks, r=me. However
- our handling here is somewhat wrong. 

Preventing default in or returning false from a mouse handler will not prevent
the checkbox or radio button from being checked, and it should.