[webkit-reviews] review denied: [Bug 4647] Generate JS Bindings should build a build rule : [Attachment 3622] Replaces build phase with build rule, moves generated files to DerivedSources

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Aug 28 16:19:48 PDT 2005


Eric Seidel <macdome at opendarwin.org> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 4647: Generate JS Bindings should build a build rule
http://bugzilla.opendarwin.org/show_bug.cgi?id=4647

Attachment 3622: Replaces build phase with build rule, moves generated files to
DerivedSources
http://bugzilla.opendarwin.org/attachment.cgi?id=3622&action=edit

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
It turns out that this only works due to the fact that I had "continue after
errors" set, and was building twice (w/o realizing).  There are header
dependencies in the generated .cpp files which this build rule approach
exposes.  Until I can find a workaround in Xcode I'm going to need to roll this
back out.



More information about the webkit-reviews mailing list