[webkit-reviews] review granted: [Bug 4672] Incorrect highlight when selection begins with space and word-spacing>0 : [Attachment 3589] add leading word space to the selection rect

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Fri Aug 26 19:35:24 PDT 2005


Darin Adler <darin at apple.com> has granted opendarwin.org at mitzpettel.com's
request for review:
Bug 4672: Incorrect highlight when selection begins with space and
word-spacing>0
http://bugzilla.opendarwin.org/show_bug.cgi?id=4672

Attachment 3589: add leading word space to the selection rect
http://bugzilla.opendarwin.org/attachment.cgi?id=3589&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Looks OK, although I'd like to see a local variable to avoid the 4 calls to
textObject(). In fact, maybe that function should be made inline.



More information about the webkit-reviews mailing list