[webkit-reviews] review granted: [Bug 4441] Merge with KDE TOT to pick up js autogeneration, etc. : [Attachment 3549] Final patch.

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Wed Aug 24 19:29:58 PDT 2005


Maciej Stachowiak <mjs at apple.com> has granted Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 4441: Merge with KDE TOT to pick up js autogeneration, etc.
http://bugzilla.opendarwin.org/show_bug.cgi?id=4441

Attachment 3549: Final patch.
http://bugzilla.opendarwin.org/attachment.cgi?id=3549&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
I reviewed the KWQSlot.mm part. I hereby rubber-stamp the rest of it. In the
future, though, we need to avoid megapatches like this - large mechanical
changes should be separated from functional changes when possible. We'll have
to think about merge strategy.



More information about the webkit-reviews mailing list