[webkit-reviews] review granted: [Bug 4585] update-webkit doesn't notice when you have SVGSupport and update properly : [Attachment 3543] Checks for SVGSupport directory, and updates accordingly

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Wed Aug 24 11:57:23 PDT 2005


Darin Adler <darin at apple.com> has granted Ben La Monica
<ben.lamonica at gmail.com>'s request for review:
Bug 4585: update-webkit doesn't notice when you have SVGSupport and update
properly
http://bugzilla.opendarwin.org/show_bug.cgi?id=4585

Attachment 3543: Checks for SVGSupport directory, and updates accordingly
http://bugzilla.opendarwin.org/attachment.cgi?id=3543&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Looks fine to me. Using $" seems unnecessarily clever when join could do the
job; it also seems a little ugly to pop the last item off of @sources and then
re-append it.

But this is a small script, and those are nits, so r=me.



More information about the webkit-reviews mailing list