[webkit-reviews] review denied: [Bug 4584] run-webkit-tests should
not print "actual expected diffs" when there are no diffs :
[Attachment 3516] don't print layout diffs unless necessary
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Mon Aug 22 11:14:17 PDT 2005
Darin Adler <darin at apple.com> has denied Tobias Lidskog
<tobiaslidskog at mac.com>'s request for review:
Bug 4584: run-webkit-tests should not print "actual expected diffs" when there
are no diffs
http://bugzilla.opendarwin.org/show_bug.cgi?id=4584
Attachment 3516: don't print layout diffs unless necessary
http://bugzilla.opendarwin.org/attachment.cgi?id=3516&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
Looks like this patch results in two extra cells when $pixelTests is 0. Should
fix that. Otherwise, seems great.
More information about the webkit-reviews
mailing list