[webkit-reviews] review granted: [Bug 4580] WebCore+SVG asserts when running JavaScript : [Attachment 3507] Adds necessary Interpreter::lock()/unlock() calls.

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Mon Aug 22 08:18:36 PDT 2005


Darin Adler <darin at apple.com> has granted Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 4580: WebCore+SVG asserts when running JavaScript
http://bugzilla.opendarwin.org/show_bug.cgi?id=4580

Attachment 3507: Adds necessary Interpreter::lock()/unlock() calls.
http://bugzilla.opendarwin.org/attachment.cgi?id=3507&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Looks fine. The APPLE_CHANGES should not be necessary, because the lock/unlock
functions should be empty inlines when locking is not necessary, but I guess
that's not how JavaScriptCore is right now.

r=me



More information about the webkit-reviews mailing list