[webkit-reviews] review granted: [Bug 4506] Support child nodes on attributes : [Attachment 3450] Support attribute children

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Thu Aug 18 09:50:38 PDT 2005

Darin Adler <darin at apple.com> has granted Anders Carlsson <andersca at mac.com>'s
request for review:
Bug 4506: Support child nodes on attributes

Attachment 3450: Support attribute children

------- Additional Comments from Darin Adler <darin at apple.com>
Didn't we talk about having a function that would replace all children with a
single text node child? Seems we could use that in AttrImpl::setValue.

I think that NodeImpl::normalize should use attributes(true) rather than
attributes() so it doesn't create an attribute if 
one isn't already present.

These are both minor issues, so r=me.

More information about the webkit-reviews mailing list