[webkit-reviews] review denied: [Bug 4299] Combine svg2png and DumpKCanvasTree into one project : [Attachment 3400] Fixed the problem with the 17 failed tests

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Mon Aug 15 17:34:06 PDT 2005


Eric Seidel <macdome at opendarwin.org> has denied Ben La Monica
<ben.lamonica at gmail.com>'s request for review:
Bug 4299: Combine svg2png and DumpKCanvasTree into one project
http://bugzilla.opendarwin.org/show_bug.cgi?id=4299

Attachment 3400: Fixed the problem with the 17 failed tests
http://bugzilla.opendarwin.org/attachment.cgi?id=3400&action=edit

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
A couple things.  1.  I don't think we should change the default
run-webkit-tests output w/o talking with darin, etc. first.  the non
"--verbose" behavior is potentially useful, but should be an additional option,
instead of default.  --quiet seems useful.

2.  you print both ->crashed and ->failed when a test fails.

3.  I'm not sure if the ability to restart the tool after a crash is a good
thing or not... 

4.  I've made some other minor cleanups and will post a consolidated patch.



More information about the webkit-reviews mailing list