[webkit-reviews] review granted: [Bug 3692] Word-spacing doesn't work as expected : [Attachment 3221] Wordspace patch with hopefully correct formatting

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Aug 14 03:54:15 PDT 2005


Maciej Stachowiak <mjs at apple.com> has granted Oliver Hunt
<ojh16 at student.canterbury.ac.nz>'s request for review:
Bug 3692: Word-spacing doesn't work as expected
http://bugzilla.opendarwin.org/show_bug.cgi?id=3692

Attachment 3221: Wordspace patch with hopefully correct formatting
http://bugzilla.opendarwin.org/attachment.cgi?id=3221&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
This does still have one minor coding style issue:

+		 if ((r->start == 0) && needsWordSpacing &&
(rt->text()[r->start].isSpace())) {
+		     effectiveWidth +=
rt->htmlFont(m_firstLine)->getWordSpacing();
+		 }


shouldn't be braces here. But let's say review+ anyway.



More information about the webkit-reviews mailing list