[webkit-reviews] review denied: [Bug 4355] use small-caps variant font if it's available : [Attachment 3287] small-caps patch 1.0

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Tue Aug 9 11:49:19 PDT 2005

Darin Adler <darin at apple.com> has denied Nicholas Shanks
<contact at nickshanks.com>'s request for review:
Bug 4355: use small-caps variant font if it's available

Attachment 3287: small-caps patch 1.0

------- Additional Comments from Darin Adler <darin at apple.com>
Please fix formatting. You need a space between the "if" and the "(" on lines

+		 if([renderer _capitalizeSmallCaps])

Also, seems better to just make the capitalizeSmallCaps field @public rather
than calling a method on every character to check that boolean.

Otherwise, looks good, and we can do review+ if we also have a layout test
demonstrating the correct behavior -- they metrics in the layout test will be
the telltale about whether the correct font and glyph was chosen.

More information about the webkit-reviews mailing list