[webkit-reviews] review granted: [Bug 4280] Would be nice if webkitdirs.pm could check system/xcode version : [Attachment 3222] Patch to add checking Xcode & OS X version to build-* scripts.

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has granted Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 4280: Would be nice if webkitdirs.pm could check system/xcode version
http://bugzilla.opendarwin.org/show_bug.cgi?id=4280

Attachment 3222: Patch to add checking Xcode & OS X version to build-* scripts.
http://bugzilla.opendarwin.org/attachment.cgi?id=3222&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
This:

    if (substr($buildVersion, 0, 1) < 8)

should just be $buildVersion < 8. The current version won't work for 10, for
example, and there's no reason to go out of the way to do substr.

But this looks fine, r=me.