<div>Hi Ossy,</div><div><br></div><div>I agree, we should wait until Qt 4.8 is released, then land this patch + rebaseline LayoutTests/platform/qt.</div><div>Requiring that people manage results from both 4.7 and 4.8 is asking too much IMO.</div>
<div><br></div><div>On a related note, qt-wk2 should already be using qt-4.8 as its fallback, but if it's indeed nontrivial, it's not a big deal.</div><div><br></div><div>Cheers,</div><div>Kling</div><div><br></div>
<div><br><div class="gmail_quote">2011/9/7 Osztrogonac Csaba <span dir="ltr"><<a href="mailto:oszi@inf.u-szeged.hu">oszi@inf.u-szeged.hu</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Hi QtWebKit developers,<br>
<br>
I ran into a serious problem what we should solve without any pain.<br>
<br>
Here is a bug report with an r+ -ed patch:<br>
<a href="https://bugs.webkit.org/show_bug.cgi?id=55036" target="_blank">https://bugs.webkit.org/show_<u></u>bug.cgi?id=55036</a><br>
[Qt] FontCache::<u></u>createFontPlatformData() is broken, a default font is returned even if the family does not match<br>
<br>
After this patch ~5000 layout test result will differ between Qt 4.7 and 4.8,<br>
which is absolutly unmaintainable. Additionally WebKit2 builds with Qt 5, but<br>
qt-wk2 platform falls back to qt platform and not qt-4.8/qt platforms.<br>
<br>
I don't know how important is this patch (AFAIK it doesn't block QtWebKit2.2 release),<br>
but I think the best solution is if we wait until Qt 4.8 relase and then we drop<br>
LayoutTests/platform/qt-4.8 platform and declare that now LayoutTests/platform/qt<br>
means Qt 4.8 results and Qt 4.7 layout test results aren't supported anymore.<br>
<br>
If we want to land this patch now, we have to<br>
- fix run-webkit-tests to be able handle qt-wk2/qt-4.8/qt fallback order (It isn't trivial fix.)<br>
- add +5000 Qt 4.8 specific layout test result into LayoutTests/platform/qt-4.8<br>
- maintain LayoutTests/platform/qt and LayoutTests/platform/qt-4.8 in parallel ( It is shocking big task !!! )<br>
<br>
What do you think about it? What should we do now?<br>
<br>
br,<br>
Csaba Osztrogonác (Ossy)<br>
University of Szeged<br>
______________________________<u></u>_________________<br>
webkit-qt mailing list<br>
<a href="mailto:webkit-qt@lists.webkit.org" target="_blank">webkit-qt@lists.webkit.org</a><br>
<a href="http://lists.webkit.org/mailman/listinfo.cgi/webkit-qt" target="_blank">http://lists.webkit.org/<u></u>mailman/listinfo.cgi/webkit-qt</a><br>
</blockquote></div><br></div>