<div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div lang="EN-US" link="blue" vlink="purple"><div><p class="MsoNormal"><font size="2" color="#1f497d" face="Arial"><span style="font-size:11.0pt;color:#1F497D">One thing that is still missing is an equivalent
to QWebPage::view(). You can get a QWidget from QWebPage, but you cannot get
QGraphicsWidget from QWebPage. Is this something you are planning to add in the
near future?</span></font></p></div></div></blockquote><div><br></div><div>Yes, Yael, that is right. And I think that this is the only inconsistency with the patch. We could add an API for this later, or at least something private that can be exported and stay hidden.</div>
<div><br></div><div>I still think that the best solution for supporting both use cases would be to have a common interface to QWidget and QGraphicsWidget specially designed for being a webview. Well, but this is something for the future...</div>
<div><br></div><div>In Symbian, are you using custom QGraphicsWidgets as webviews or are you all using QGraphicsWebView? This would help answering some of Simon's questions: why do we need this? Where is QGraphicsWebView failing?</div>
<div><br></div><div>Thanks for all comments!</div><div>Jesus</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div lang="EN-US" link="blue" vlink="purple">
<div>
<p class="MsoNormal"><font size="2" color="#1f497d" face="Arial"><span style="font-size:11.0pt;color:#1F497D"> </span></font></p>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal" style="margin-left:.5in"><b><font size="2" face="Tahoma"><span style="font-size:10.0pt;font-weight:bold">From:</span></font></b><font size="2" face="Tahoma"><span style="font-size:10.0pt"> <a href="mailto:webkit-qt-bounces@lists.webkit.org" target="_blank">webkit-qt-bounces@lists.webkit.org</a>
[mailto:<a href="mailto:webkit-qt-bounces@lists.webkit.org" target="_blank">webkit-qt-bounces@lists.webkit.org</a>] <b><span style="font-weight:bold">On
Behalf Of </span></b>ext Jesus Sanchez-Palencia<br>
<b><span style="font-weight:bold">Sent:</span></b> Thursday, April 29, 2010
9:03 AM<br>
<b><span style="font-weight:bold">To:</span></b> <a href="mailto:webkit-qt@lists.webkit.org" target="_blank">webkit-qt@lists.webkit.org</a><br>
<b><span style="font-weight:bold">Subject:</span></b> [webkit-qt] PageClient
Refactor and a new setView() use case</span></font></p>
</div><div><div></div><div class="h5">
<p class="MsoNormal" style="margin-left:.5in"><font size="3" face="Times New Roman"><span style="font-size:12.0pt"> </span></font></p>
<p class="MsoNormal" style="margin-left:.5in"><font size="3" face="Times New Roman"><span style="font-size:12.0pt">Hello there, QtWebKit hackers!</span></font></p>
<div>
<p class="MsoNormal" style="margin-left:.5in"><font size="3" face="Times New Roman"><span style="font-size:12.0pt"> </span></font></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><font size="3" face="Times New Roman"><span style="font-size:12.0pt">I've been working on a PageClient refactor for
QtWebKit.</span></font></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><font size="3" face="Times New Roman"><span style="font-size:12.0pt">The main motivation for this came from the fact that
nowadays our API has QWebPage::setView(QWidget*) but has nothing to deal
with QGraphicsWidgets.</span></font></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><font size="3" face="Times New Roman"><span style="font-size:12.0pt">People were starting to do
QWebPage::setView(QGraphicsView*), but this was leading us to bugs since the
API is not ready to deal with the QGraphicsView family.</span></font></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><font size="3" face="Times New Roman"><span style="font-size:12.0pt"> </span></font></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><font size="3" face="Times New Roman"><span style="font-size:12.0pt">So, I've prepared 2 patches for this:</span></font></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><font size="3" face="Times New Roman"><span style="font-size:12.0pt"> </span></font></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><font size="3" face="Times New Roman"><span style="font-size:12.0pt">- one refactor for the QWidget's PageClient (<a href="https://bugs.webkit.org/show_bug.cgi?id=37858" target="_blank">https://bugs.webkit.org/show_bug.cgi?id=37858</a>),
which is already landed;</span></font></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><font size="3" face="Times New Roman"><span style="font-size:12.0pt"> </span></font></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><font size="3" face="Times New Roman"><span style="font-size:12.0pt">- and a more complex one for adding a QGraphicsWidget
PageClient and a QWebPage::setView(QGraphicsWidget*) (<a href="https://bugs.webkit.org/show_bug.cgi?id=37866" target="_blank">https://bugs.webkit.org/show_bug.cgi?id=37866</a>). </span></font></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><font size="3" face="Times New Roman"><span style="font-size:12.0pt"> </span></font></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><font size="3" face="Times New Roman"><span style="font-size:12.0pt"> </span></font></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><font size="3" face="Times New Roman"><span style="font-size:12.0pt">This last one, basically, moved code from
QGraphicsWebViewPrivate (including Tiling and AC specific stuff) to a
"real" PageClient and removed the inheritance from it (this private
class _was_, in fact, the PageClient of the QGraphicsWebView).</span></font></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><font size="3" face="Times New Roman"><span style="font-size:12.0pt"> </span></font></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><font size="3" face="Times New Roman"><span style="font-size:12.0pt">I'd like some feedback from you in order to understand
what do you think about this patch and if you consider this new setView API a
valid use case or not.</span></font></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><font size="3" face="Times New Roman"><span style="font-size:12.0pt">I'm aware that Plasma (from KDE) is using it and that
it might be useful for the QML folks.</span></font></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><font size="3" face="Times New Roman"><span style="font-size:12.0pt"> </span></font></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><font size="3" face="Times New Roman"><span style="font-size:12.0pt">Also, should this go into QtWebKit 2.0 or should we
just leave it for QtWebKit 2.1?</span></font></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><font size="3" face="Times New Roman"><span style="font-size:12.0pt"> </span></font></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><font size="3" face="Times New Roman"><span style="font-size:12.0pt">I already have the r+ for the patch, but we agreed to
wait for this discussion before deciding when to land it.</span></font></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><font size="3" face="Times New Roman"><span style="font-size:12.0pt"> </span></font></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><font size="3" face="Times New Roman"><span style="font-size:12.0pt"> </span></font></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><font size="3" face="Times New Roman"><span style="font-size:12.0pt">Best regards,</span></font></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><font size="3" face="Times New Roman"><span style="font-size:12.0pt">Jesus </span></font></p>
</div>
</div></div></div>
</div>
</blockquote></div><br>