[webkit-qt] Interfaces to whitelist origins in QtWebkit API (your thoughts please!)
jocelyn.turcotte at digia.com
Thu Mar 21 04:18:22 PDT 2013
On Thu, Mar 21, 2013 at 04:09:14AM +0000, Saha, Deepjyoti wrote:
> Hi Jocelyn,
> Thanks for the response! :-)
> Yes, even I feel that these API's can be implemented as static functions and I would like to submit a patch for this.
> But it can be done in QWebSecurityOrigin (as you suggested) or be implemented in a new class "QWebSecurityPolicy" (to maintain the coherence between classes in QtWebkit and WebCore) ?
> Please let me know your opinion.
QWebSecurityOrigin should be fine, I think it's preferable not to create a new class if it is only going to contain static functions.
> I checked the bug you mentioned:
> https://bugs.webkit.org/show_bug.cgi?id=31875 (Impossible to make XMLHttpRequest from locally stored HTML page)
> So this patch can be submiited under the existing bug report itself correct ?
Ideally you should start from the work already done in the patch there (if it would also solves your use case).
Since Simon started it I think that it would be best if you get his opinion first. I don't know if you can simply expose WebCore functions in QWebSecurityOrigin or if this would need some closer attention.
He's on vacation right now so you might have to wait 2 weeks to be able to find him.
More information about the webkit-qt