[webkit-qt] Adding a "view source" API for WebView [feedback needed!]

[Jesus Sanchez-Palencia]

On Thu, May 10, 2012 at 9:59 AM, Jocelyn Turcotte <
jocelyn.turcotte at nokia.com> wrote:

> On Thu, 10 May 2012 09:43:23 -0300
> ext Jesus Sanchez-Palencia <jesus at webkit.org> wrote:
>
> > So you don't think we should support "view-source:www.foo.com", right?
> > (Note the absence of a second - http - scheme). Not sanitizing them will
> > make us only support well-formed URLs (view-source:http://www.foo.com).
>
> Humm looks like Chrome supports this pretty well, so I'm not against it
> either.
> In any case I think that it's possible to do the sanitization in
> Utils::urlFromUserInput like you did, whether or not the flag is passed as
> the view-source URL scheme or as a separate message.
>


Yes, ok, but then the url scheme logic wouldn't sit only on the WebProcess
as Tor Arne suggested. Plus, imagine that we decide to support this through
the "view-source:" url way and keep all the logic on the WebProcess. If the
API user doesn't do anything else he would only get support for well-formed
URLs. For the other use case (view-source:www.foo.com) he would need url
sanitizing code from himself... On the very least this would need to be
well documented.

I'm not arguing against anything here, I'm just pointing the trade offs of
each solution so we can reach a conclusion and a final patch can be
implemented.


cheers!
jesus
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-qt/attachments/20120510/de6bedab/attachment.html>