[webkit-qt] QtWebKit --minimal build with minimal Qt
abecsi at webkit.org
Wed Sep 28 01:27:43 PDT 2011
On 27 September 2011 17:29, Andreas Kling <kling at webkit.org> wrote:
> On Tue, Sep 27, 2011 at 5:12 PM, Tor Arne Vestbø <tor.arne.vestbo at nokia.com>
>> On 27.09.11 16:55, noam.rosenthal at nokia.com wrote:
>>> On Sep 27, 2011, at 3:49 PM, ext Osztrogonac Csaba wrote:
>>>> "Qt Linux Release minimal" is core builder on
>>>> http://build.webkit.org/waterfall?category=core .
>>>> If we don't support QT_NO_* officially and let the community fix
>>>> problems, we have to disable CONFIG+=qt_minimal on this bot,
>>>> because a core builder must be green almost at all times.
>>> IMO that's sensible. Do we provide guidance for people who want to
>>> maintain their own bots where they can test those configurations?
>> I agree. Having a core builder that builds a minimal _WebKit_ build is
>> something we should strive for, and enabling CONFIG+=qt_minimal makes that
>> bot more fragile and less useful for other ports
> Seconded. The Qt Minimal bot should be minimal WebKit, and that's already on
> the edge of what we can reasonably expect non-Qt WebKit contributors to care
> about. I'm fine with keeping the QT_NO_* stuff in place if it's explicitly
> unsupported and doesn't grow into anything beyond disabled code blocks here
> and there.
Second on this, too.
If we keep the QT_NO* guards in tree we have to document somewhere
that this is not officially supported. The minimal bot is otherwise an
important one since it is the only one testing the correctness of at
least a default set of the gadzillion WebKit guards.
More information about the webkit-qt