[webkit-qt] QtWebKit --minimal build with minimal Qt

[Andreas Kling]

Heyo, interesting topic!

In my opinion all QT_NO_* defines should be dropped from WebKit. I
believe QtWebKit is sufficiently complex that you shouldn't use it without a
fully-featured Qt.

For every additional build-time flag, the complexity matrix grows larger,
and we're not testing any of it beyond building with all those flags enabled
together. If we do need to support that, I'd rather we had a monolithic
USE(LESS_QTWEBKIT) flag rather than separate ones.

(inb4 embedded people yelling at me)

Hugs,
Kling


On Tue, Sep 27, 2011 at 3:52 PM, Osztrogonac Csaba <oszi at inf.u-szeged.hu>wrote:

> Hi QtWebKit developers,
>
> The "Qt Linux Release minimal" buildbot on http://build.webkit.org is
> our ifdef guard protector buildbot. It builds WebKit with this command:
> Tools/Scripts/build-webkit --release --qt --minimal CONFIG+=qt_minimal
> ( details: http://build.webkit.org/**buildslaves/szeged-linux-2<http://build.webkit.org/buildslaves/szeged-linux-2>)
>
> My question is if QtWebKit community still need supporting QT_NO_* guards
> in WebKit
> trunk or not. If yes, which ones are still necessary and which ones can we
> drop?
>
> br,
> Ossy
>
>
> Minimal Qt means that Qt was built the following QT_NO_* defines:
> ------------------------------**------------------------------**------
> #define QT_NO_ANIMATION
> #define QT_NO_BEARERMANAGEMENT
> #define QT_NO_CLIPBOARD
> #define QT_NO_COMBOBOX
> #define QT_NO_CONCURRENT
> #define QT_NO_CRASHHANDLER
> #define QT_NO_CURSOR
> #define QT_NO_DESKTOPSERVICES
> #define QT_NO_FILEDIALOG
> #define QT_NO_GRAPHICSEFFECT
> #define QT_NO_IM
> #define QT_NO_INPUTDIALOG
> #define QT_NO_LINEEDIT
> #define QT_NO_MESSAGEBOX
> #define QT_NO_OPENSSL
> #define QT_NO_PRINTER
> #define QT_NO_QUUID_STRING
> #define QT_NO_SHORTCUT
> #define QT_NO_STYLE_STYLESHEET
> #define QT_NO_SYSTEMTRAYICON
> #define QT_NO_TEMPORARYFILE
> #define QT_NO_TOOLTIP
> #define QT_NO_UITOOLS
> #define QT_NO_UNDOCOMMAND
> #define QT_NO_UNDOSTACK
> #define QT_NO_XRENDER
>
> And the configure options:
> ---------------------------
> -qconfig webkit-minimal
> -platform linux-g++-32
> -embedded
> -nomake demos
> -nomake docs
> -nomake examples
> -no-webkit
> -no-openssl
> -no-declarative
> -no-scripttools
> -opensource
> ______________________________**_________________
> webkit-qt mailing list
> webkit-qt at lists.webkit.org
> http://lists.webkit.org/**mailman/listinfo.cgi/webkit-qt<http://lists.webkit.org/mailman/listinfo.cgi/webkit-qt>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-qt/attachments/20110927/529ceb0c/attachment.html>