[webkit-qt] Maintaining Qt 4.7 and 4.8 expected results in parallel

laszlo.1.gombos at nokia.com laszlo.1.gombos at nokia.com
Wed Sep 7 18:14:32 PDT 2011

Hi Ossy,

I second that. First release of QtWebKit 2.2 (2.2.0) should be baselined on top of Qt 4.7 and QtWebKit 2.2.1 should come with results for Qt 4.8 (and try not to regress between QtWebKit releases).


From: webkit-qt-bounces at lists.webkit.org [mailto:webkit-qt-bounces at lists.webkit.org] On Behalf Of ext Andy Kling
Sent: Wednesday, September 07, 2011 10:30 AM
To: Osztrogonac Csaba
Cc: webkit-qt at lists.webkit.org
Subject: Re: [webkit-qt] Maintaining Qt 4.7 and 4.8 expected results in parallel

Hi Ossy,

I agree, we should wait until Qt 4.8 is released, then land this patch + rebaseline LayoutTests/platform/qt.
Requiring that people manage results from both 4.7 and 4.8 is asking too much IMO.

On a related note, qt-wk2 should already be using qt-4.8 as its fallback, but if it's indeed nontrivial, it's not a big deal.


2011/9/7 Osztrogonac Csaba <oszi at inf.u-szeged.hu<mailto:oszi at inf.u-szeged.hu>>
Hi QtWebKit developers,

I ran into a serious problem what we should solve without any pain.

Here is a bug report with an r+ -ed patch:
[Qt] FontCache::createFontPlatformData() is broken, a default font is returned even if the family does not match

After this patch ~5000 layout test result will differ between Qt 4.7 and 4.8,
which is absolutly unmaintainable. Additionally WebKit2 builds with Qt 5, but
qt-wk2 platform falls back to qt platform and not qt-4.8/qt platforms.

I don't know how important is this patch (AFAIK it doesn't block QtWebKit2.2 release),
but I think the best solution is if we wait until Qt 4.8 relase and then we drop
LayoutTests/platform/qt-4.8 platform and declare that now LayoutTests/platform/qt
means Qt 4.8 results and Qt 4.7 layout test results aren't supported anymore.

If we want to land this patch now, we have to
- fix run-webkit-tests to be able handle qt-wk2/qt-4.8/qt fallback order (It isn't trivial fix.)
- add +5000 Qt 4.8 specific layout test result into LayoutTests/platform/qt-4.8
- maintain LayoutTests/platform/qt and LayoutTests/platform/qt-4.8 in parallel ( It is shocking big task !!! )

What do you think about it? What should we do now?

Csaba Osztrogonác (Ossy)
University of Szeged
webkit-qt mailing list
webkit-qt at lists.webkit.org<mailto:webkit-qt at lists.webkit.org>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-qt/attachments/20110908/7f10ab27/attachment.html>

More information about the webkit-qt mailing list