[webkit-qt] Maintaining Qt 4.7 and 4.8 expected results in parallel
oszi at inf.u-szeged.hu
Wed Sep 7 07:11:30 PDT 2011
Hi QtWebKit developers,
I ran into a serious problem what we should solve without any pain.
Here is a bug report with an r+ -ed patch:
[Qt] FontCache::createFontPlatformData() is broken, a default font is returned even if the family does not match
After this patch ~5000 layout test result will differ between Qt 4.7 and 4.8,
which is absolutly unmaintainable. Additionally WebKit2 builds with Qt 5, but
qt-wk2 platform falls back to qt platform and not qt-4.8/qt platforms.
I don't know how important is this patch (AFAIK it doesn't block QtWebKit2.2 release),
but I think the best solution is if we wait until Qt 4.8 relase and then we drop
LayoutTests/platform/qt-4.8 platform and declare that now LayoutTests/platform/qt
means Qt 4.8 results and Qt 4.7 layout test results aren't supported anymore.
If we want to land this patch now, we have to
- fix run-webkit-tests to be able handle qt-wk2/qt-4.8/qt fallback order (It isn't trivial fix.)
- add +5000 Qt 4.8 specific layout test result into LayoutTests/platform/qt-4.8
- maintain LayoutTests/platform/qt and LayoutTests/platform/qt-4.8 in parallel ( It is shocking big task !!! )
What do you think about it? What should we do now?
Csaba Osztrogonác (Ossy)
University of Szeged
More information about the webkit-qt