[webkit-qt] decidePolicyForNavigationAction QML API

Chang.Shu at nokia.com Chang.Shu at nokia.com
Thu Oct 13 11:58:03 PDT 2011


Agree. Using functions feels like the 1st call makes effect while using
booleans feels like multiple decisions are made. I also vote for enums as
it's mutual exclusive thus clear.

Chang
On 10/13/11 2:48 PM, "ext Caio Marcelo de Oliveira Filho"
<caio.oliveira at openbossa.org> wrote:

>On Thu, Oct 13, 2011 at 3:40 PM,  <simon.hausmann at nokia.com> wrote:
>> I think you need only two, no?
>>
>> request.accepted = true
>>
>> or
>>
>> request.accepted = false
>>
>> and
>>
>> request.download = true
>> (which could imply accepted = false)
>
>This is confusing... I think using three functions for the three
>possible answers is better.
>
>If this is async, the request can outlive the function that handles
>the signal, this is not the case for mouse.accepted, it needs to be
>decided before the event handler function returns.
>
>If you want to avoid functions, an enumeration is better than two
>booleans.
>
>
>Cheers,
>
>-- 
>Caio Marcelo de Oliveira Filho
>OpenBossa - INdT
>_______________________________________________
>webkit-qt mailing list
>webkit-qt at lists.webkit.org
>http://lists.webkit.org/mailman/listinfo.cgi/webkit-qt



More information about the webkit-qt mailing list